Remove use of eval() from operators.py #4888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
np.float32()
instead.What problem does this PR solve?
Using
eval()
can lead to code injections.I think
eval()
is only used to parse a floating point number here. This change preserves the correct behavior if the string"None"
is supplied. But if that behavior isn't intended then this part could be just deleted instead, sincenp.float32()
is parsing strings anyway:Type of change