-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show graphql operation name for graphql requests #1521
base: master
Are you sure you want to change the base?
feat: show graphql operation name for graphql requests #1521
Conversation
The contributing guide, unfortunately, doesn't specify who should be marked as the reviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for such a long delay in this. I had a couple of moments this morning and had the tab still open 😅 I haven't had a chance to fully test this out with a GraphQL API & Apollo Client. I'll look at doing that next week.
lib/reactotron-core-ui/src/timelineCommands/ApiResponseCommand/index.tsx
Outdated
Show resolved
Hide resolved
@yurik256 thanks for the contribution! Do you have the time to make the requested changes by Nick? If not let us know and we can try to bring it up to speed. |
@frankcalise thanks for following up! I somehow missed the message from @morganick :( I tried changing the order so that we show the operation name before the URL, and that makes it visually hard to parse. |
@yurik256 I'm good with putting it after the URL. I'd love to update the design of the timeline to accommodate for things like this. It gets lost a bit either way, but I agree that after is easier on the eyes because of the uniformity of the pattern in |
Please verify the following:
yarn build-and-test:local
passesREADME.md
(or relevant documentation) has been updated with your changesDescribe your PR
On the react native project I'm working on, we are extensively using graphql.
Current implement of timeline plugin, makes it hard to differentiate graphql requests, as they are all shown as
POST /graphql
in the timelineThis PR improves this by adding the following
request.operationName
field, which is automatically added for all graphql requests made by@apollo/client
Screenshots
Show operation name
Ability to search by request data ( in this case, operation name )