Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note removal of Flux MQTT package support OSS 2.7+ #5634

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

sanderson
Copy link
Collaborator

Closes influxdata/DAR#437

Adds a warning to the top of the experimental/mqtt package and function pages:

image

Removes support from InfluxDB OSS 2.7+ and nightly in the InfluxDB version support modal:

image
  • Rebased/mergeable

@davidby-influx
Copy link

I don't think mqtt is supported by any of the OSS builds, not merely 2.7????

data/flux_stdlib_frontmatter.yml Outdated Show resolved Hide resolved
data/flux_stdlib_frontmatter.yml Outdated Show resolved Hide resolved
data/flux_stdlib_frontmatter.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@jstirnaman jstirnaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending David's approval.

Copy link

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion.

content: |
#### Not supported in InfluxDB OSS 2.7+

The `experimental/mqtt` package is not supported in InfluxDB 2.7+, but

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to say InfluxDB OSS 2.x or whatever we use to designate all the OSS 2 versions. Say 2,7/= implies it is supported in earlier 2,x versions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was support for it removed from all previous v2 versions?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was ever supported on 2.X OSS.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then that likely means it was never supported in OSS v1 as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it, but have never tested it. I suspect that it was only usable in C2.

Copy link
Collaborator Author

@sanderson sanderson Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidby-influx I just pushed a change that removes support from all InfluxDB versions except InfluxDB Cloud 2 (TSM). I also updated the text in the warning.

Side question--does this package rely on dependencies outside of the Flux runtime? Why does this work in Cloud, but not anything else?

@sanderson sanderson merged commit 44ce6e9 into master Oct 4, 2024
1 check passed
jstirnaman added a commit that referenced this pull request Oct 25, 2024
* WIP added prepend to mqtt package frontmatter

* WIP excluded mqtt package from oss 2.7+

* WIP add nightly version exclude

* add nightly exclude to flux function support modal, closes influxdata/DAR#437

* updated mqtt warn message and version exclude pattern

* Apply suggestions from code review

Co-authored-by: Jason Stirnaman <[email protected]>

* exclude mqtt package from all oss versions

* exclude mqtt package from everything but cloud

---------

Co-authored-by: Jason Stirnaman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants