-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note removal of Flux MQTT package support OSS 2.7+ #5634
Conversation
I don't think |
Co-authored-by: Jason Stirnaman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending David's approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion.
data/flux_stdlib_frontmatter.yml
Outdated
content: | | ||
#### Not supported in InfluxDB OSS 2.7+ | ||
|
||
The `experimental/mqtt` package is not supported in InfluxDB 2.7+, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to say InfluxDB OSS 2.x
or whatever we use to designate all the OSS 2 versions. Say 2,7/=
implies it is supported in earlier 2,x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was support for it removed from all previous v2 versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it was ever supported on 2.X OSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then that likely means it was never supported in OSS v1 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it, but have never tested it. I suspect that it was only usable in C2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidby-influx I just pushed a change that removes support from all InfluxDB versions except InfluxDB Cloud 2 (TSM). I also updated the text in the warning.
Side question--does this package rely on dependencies outside of the Flux runtime? Why does this work in Cloud, but not anything else?
* WIP added prepend to mqtt package frontmatter * WIP excluded mqtt package from oss 2.7+ * WIP add nightly version exclude * add nightly exclude to flux function support modal, closes influxdata/DAR#437 * updated mqtt warn message and version exclude pattern * Apply suggestions from code review Co-authored-by: Jason Stirnaman <[email protected]> * exclude mqtt package from all oss versions * exclude mqtt package from everything but cloud --------- Co-authored-by: Jason Stirnaman <[email protected]>
Closes influxdata/DAR#437
Adds a warning to the top of the
experimental/mqtt
package and function pages:Removes support from InfluxDB OSS 2.7+ and nightly in the InfluxDB version support modal: