Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InfluxDB.flush() #292

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Conversation

jganoff
Copy link
Contributor

@jganoff jganoff commented Feb 28, 2017

InfluxDB.flush() was introduced as a mechanism for flushing the underlying BatchProcessor without shutting it down. It's a step toward being able to guarantee all asynchronously queued points are delivered at a given time when operating in batch mode. See #289 for more context. This doesn't change the failure handling for BatchProcessor.write() so records may still be silently dropped as a result of flushing.

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

Merging #292 into master will decrease coverage by -0.24%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
- Coverage     78.47%   78.23%   -0.24%     
- Complexity      130      132       +2     
============================================
  Files            11       11              
  Lines           706      712       +6     
  Branches         77       77              
============================================
+ Hits            554      557       +3     
- Misses          109      112       +3     
  Partials         43       43
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/InfluxDB.java 100% <ø> (ø) 0 <0> (ø)
...rc/main/java/org/influxdb/impl/BatchProcessor.java 97.95% <100%> (+0.04%) 17 <1> (+1)
src/main/java/org/influxdb/impl/InfluxDBImpl.java 79.51% <100%> (-1.09%) 40 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c29a3...4bf7459. Read the comment docs.

@majst01 majst01 merged commit 30fa0ee into influxdata:master Feb 28, 2017
@jganoff jganoff deleted the feature-289-flush branch February 28, 2017 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants