Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continuous integration #773

Merged
merged 6 commits into from
Sep 15, 2021
Merged

fix: continuous integration #773

merged 6 commits into from
Sep 15, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Sep 13, 2021

  1. Fixed sys env expansion in GitHub workflow
  2. Fixed flaky tests:
    • BatchOptionsTest.testJitterDuration
    • MessagePackBatchOptionsTest.testWriteWithRetryOnRecoverableError
  3. Fixed MessagePackInfluxDBTest.testChunkingQueryPost - MessagePack response doesn't contains last empty response

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #773 (ced2b74) into master (920aa06) will increase coverage by 6.18%.
The diff coverage is 100.00%.

❗ Current head ced2b74 differs from pull request most recent head 4bc9cb2. Consider uploading reports for the commit 4bc9cb2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #773      +/-   ##
============================================
+ Coverage     54.99%   61.18%   +6.18%     
- Complexity      390      440      +50     
============================================
  Files            70       70              
  Lines          2575     2576       +1     
  Branches        270      270              
============================================
+ Hits           1416     1576     +160     
+ Misses         1093      931     -162     
- Partials         66       69       +3     
Impacted Files Coverage Δ
...rc/main/java/org/influxdb/impl/BatchProcessor.java 97.98% <100.00%> (+0.01%) ⬆️
src/main/java/org/influxdb/impl/InfluxDBImpl.java 82.65% <0.00%> (+3.37%) ⬆️
...uxdb/msgpack/MessagePackResponseBodyConverter.java 100.00% <0.00%> (+75.00%) ⬆️
...ava/org/influxdb/msgpack/MessagePackTraverser.java 87.23% <0.00%> (+87.23%) ⬆️
...ava/org/influxdb/msgpack/QueryResultModelPath.java 90.00% <0.00%> (+90.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920aa06...4bc9cb2. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Sep 13, 2021

I have seen you pushed directly to master, please never do this !

@bednar
Copy link
Contributor Author

bednar commented Sep 13, 2021

I have seen you pushed directly to master, please never do this !

Ok, sorry for that.

@bednar
Copy link
Contributor Author

bednar commented Sep 13, 2021

@majst01 The GitHub Checks pass five times, so I think that the flaky tests are fixed.

@bednar bednar marked this pull request as ready for review September 13, 2021 09:34
@bednar bednar requested a review from majst01 September 13, 2021 09:34
@majst01 majst01 merged commit e2ed4ea into master Sep 15, 2021
@majst01 majst01 deleted the fix/ci-builds branch September 15, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants