This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
Fix for from_DSN() constructor when using DataFrameClient #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Can we have a test for this? |
|
@aviau I've added a test to confirm that the DataFrameClient subclass is returned when using the from_DSN() method. Let me know if you had something else in mind. |
|
That is great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an instance of
DataFrameClientusing thefrom_DSN()constructor, an instance ofInfluxDBClientis returned instead. This change returns the correct instance type.See also issue #381