build: more fixes for CircleCI cross-build setup #20499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Jan 12, 2021
| - cross_build: | ||
| requires: | ||
| - godeps | ||
| - jsdeps |
There was a problem hiding this comment.
I am torn between running this on every PR (catches problems early, but slow) and only running it on master. Thoughts?
There was a problem hiding this comment.
Better I think to weed out problems early.
|
Ugh, spoke too soon. Failed job popped up here. |
|
We might be intermittently running into docker/buildx#495 |
|
Closing this for now to reduce spam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20479
Even with #20484 I was seeing intermittent failures on
master. I haven't seen a failure (yet) with these changes, so fingers crossed...buildxplugin onto whatever happens to be therearm64buildxbuilder