Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(timeouts): increases timeouts #33

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

RohanSreerama5
Copy link

@RohanSreerama5 RohanSreerama5 commented Aug 20, 2024

Updates default Wirey timeout values and also makes them configurable via the environment.

Usage notes:

The following parameters can be set via the environment. Please be sure to specify the unit, ie. seconds minutes. Values are parsed as time.Duration values.

Here's an example:

export DIAL_TIMEOUT="25s"
export TLS_HANDSHAKE_TIMEOUT="20s"
export CLIENT_TIMEOUT="1m"

All configurable parameters:

backend/http.go
DIAL_TIMEOUT
TLS_HANDSHAKE_TIMEOUT
CLIENT_TIMEOUT

backend/plumber.go
MAX_ELAPSED_TIME
MAX_INTERVAL
JITTER_RANGE

backend/etcd.go
ETCD_DIAL_TIMEOUT

@RohanSreerama5
Copy link
Author

What do folks think of the timeout values in the PR? I can optionally also adjust the timeouts in here

@emoruzzi
Copy link

can we make that etcd value you mentioned configurable too. once completed, we would need to update the ansible wirey role to handle env vars to release this

https://github.com/influxdata/cloud1-awx/blob/GLaDOS/roles/wirey/

@RohanSreerama5 RohanSreerama5 changed the base branch from master to devel August 21, 2024 18:12
@RohanSreerama5
Copy link
Author

RohanSreerama5 commented Aug 21, 2024

can we make that etcd value you mentioned configurable too. once completed, we would need to update the ansible wirey role to handle env vars to release this

https://github.com/influxdata/cloud1-awx/blob/GLaDOS/roles/wirey/

Yup, my commit makes the ETCD_DIAL_TIMEOUT also configurable via the environment.

@RohanSreerama5 RohanSreerama5 merged commit 15b9d32 into devel Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants