Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve eid handling #1100

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

make-github-pseudonymous-again
Copy link
Contributor

The goal is to fix the following issues:

This is progress on the following issues:

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 95.35519% with 17 lines in your changes missing coverage. Please review.

Project coverage is 73.24%. Comparing base (5effc48) to head (bfd59e1).

Files with missing lines Patch % Lines
imports/ui/drag-and-drop/handleDrop.ts 37.50% 3 Missing and 2 partials ⚠️
imports/api/endpoint/patients/update.ts 83.33% 0 Missing and 2 partials ⚠️
imports/api/patients.ts 71.42% 2 Missing ⚠️
imports/ui/App.tsx 80.00% 1 Missing and 1 partial ⚠️
imports/api/drugs/insertDrugs.ts 0.00% 1 Missing ⚠️
...mports/api/transaction/TestingTransactionDriver.ts 50.00% 1 Missing ⚠️
imports/migrations/versions/v1.ts 83.33% 1 Missing ⚠️
imports/ui/eid/EidCardDialog.tsx 66.66% 0 Missing and 1 partial ⚠️
...ts/ui/eid/EidCardDialogStepPreviewSingleCreate.tsx 50.00% 1 Missing ⚠️
imports/ui/eid/EidCardDialogStepSelection.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   70.90%   73.24%   +2.33%     
==========================================
  Files         763      772       +9     
  Lines       11579    11915     +336     
  Branches     1446     1455       +9     
==========================================
+ Hits         8210     8727     +517     
+ Misses       2881     2692     -189     
- Partials      488      496       +8     
Flag Coverage Δ
client 53.28% <36.06%> (+0.92%) ⬆️
server 61.85% <86.84%> (+1.31%) ⬆️
test 77.76% <88.25%> (+0.55%) ⬆️
test-app 58.34% <84.72%> (+2.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This makes it easier to write tests based on accessible attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split eid info
1 participant