Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NoMerge] Patch gaia6 to support ordered transfer channel #63

Closed
wants to merge 3 commits into from
Closed

[NoMerge] Patch gaia6 to support ordered transfer channel #63

wants to merge 3 commits into from

Conversation

soareschen
Copy link
Collaborator

@soareschen soareschen commented Feb 16, 2022 •
edited
Loading

This is for testing informalsystems/hermes#1835.

@soareschen
Copy link
Collaborator Author

@JonathanLorimer it seems like no matter what replace directive is used, it is always ignored by the Nix go builder. This is probably the same bug as nix-community/gomod2nix#26.

@soareschen soareschen mentioned this pull request Feb 16, 2022
Closed
5 tasks
@JonathanLorimer
Copy link
Collaborator

I wonder if the issue is here

@soareschen
Copy link
Collaborator Author

@JonathanLorimer it seems like the quirk is probably in the Go code for gomod2nix. I tried editing go-modules.toml manually in ea7f02f, and my patch is now working.

@soareschen
Copy link
Collaborator Author

Turns out the fix is rather simple: nix-community/gomod2nix#30

@JonathanLorimer
Copy link
Collaborator

closing due to #64

@soareschen soareschen mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soareschen @JonathanLorimer