Add Reconciler #184
Draft
Add Reconciler #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthwang-metal
force-pushed
the
sthwang/add-reconciler
branch
from
01e01f3 to
c6ee620
Compare
Signed-off-by: Stephen Hwang <[email protected]>
sthwang-metal
force-pushed
the
sthwang/add-reconciler
branch
6 times, most recently
from
2bde102 to
4866565
Compare
Signed-off-by: Stephen Hwang <[email protected]>
sthwang-metal
force-pushed
the
sthwang/add-reconciler
branch
from
4866565 to
a3f78e4
Compare
sthwang-metal
force-pushed
the
sthwang/add-reconciler
branch
from
f0b85a7 to
808707c
Compare
Signed-off-by: Stephen Hwang <[email protected]>
sthwang-metal
force-pushed
the
sthwang/add-reconciler
branch
from
808707c to
609f488
Compare
rizzza
reviewed
Jul 9, 2024
| return errMissingReconcilerInterval | ||
| } | ||
|
|
||
| ticker := time.NewTicker(interval) |
There was a problem hiding this comment.
you'll wanna add a defer ticker.Stop()? to cleanup before exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds the reconciler that will fix out of sync resources by deleting extra namespaces/loadbalancers and create missing namespaces/loadbalancers.
Some design decisions:
Note: will add some tests and wont merge this till I do
Note: go.mod is pointing load-balancer-api to my fork but will change it once this gets merged and released: infratographer/load-balancer-api#353