fix(localize,form-core): wait for localize before updating feedback

[jorenbroekema]

fixes #1446

[changeset-bot]

🦋 Changeset detected

Latest commit: 8a76664

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages

Name	Type
@lion/form-core	Minor
@lion/localize	Minor
@lion/checkbox-group	Patch
@lion/combobox	Patch
@lion/fieldset	Patch
@lion/form-integrations	Patch
@lion/input-amount	Patch
@lion/input-date	Patch
@lion/input-datepicker	Patch
@lion/input-email	Patch
@lion/input-iban	Patch
@lion/input-stepper	Patch
@lion/input	Patch
@lion/listbox	Patch
@lion/radio-group	Patch
@lion/select-rich	Patch
@lion/select	Patch
@lion/switch	Patch
@lion/textarea	Patch
@lion/validate-messages	Patch
@lion/calendar	Patch
@lion/input-range	Patch
@lion/pagination	Patch
@lion/progress-indicator	Patch
@lion/form	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[jorenbroekema]

This was failing because "Tekst" was still "Text" from the old locale. Now that it awaits localize.loadingComplete, it will get the right localized label in the feedback message

[tlouisse]

Nice catch and fix.

Maybe we can solve it in a way such that ValidateMixin (and with that the complete form-core package) becomes i18n system agnostic?
See: https://github.com/ing-bank/lion/blob/master/packages/form-core/src/validate/ValidateMixin.js#L3 😬

We should actually get rid of the lines here: https://github.com/ing-bank/lion/blob/master/packages/form-core/src/validate/ValidateMixin.js#L256

Maybe we can solve it with a controller, like this?

form-core: localization system agnostic


// ValidateManager
export class ValidateManager {
    
  addLocalizeController(ctrl) {
       
    this.localizeControllers.push(ctrl);
    
  }

}
ValidateManager.localizeControllers = [];


// ValidateMixin

import { ValidateManager } from ‘./ValidateManager.js’;




...
constructor() {
  

ValidateManager.localizeControllers.forEach(ctrl => {
    ctrl(this);
  });

}


...

validate-messages


import { ValidateManager } from ‘@lion/form-core’;

import {localize} from ‘@lion/localize;



ValidateManager.addLocalizeController(class LionLocalizeController {
 
 ...
hostConnected() {
   
   localize.addEventListener('localeChanged', this._updateValidateMixinFeedbackComponent);
  
}
  
...
async _updateValidateMixinFeedbackComponent(ev) {
	
  await localize.loadingComplete;
	
  this.host._updateFeedbackComponent(ev);
  
}

});

[tlouisse]

If the proposal is a bit too much and you need the fix on a short term, we can also merge this fix and add the proposal as an issue/idea 👍