Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native types: warn for implict conversion to any #8576

Closed
wouterdb opened this issue Jan 7, 2025 · 1 comment
Closed

native types: warn for implict conversion to any #8576

wouterdb opened this issue Jan 7, 2025 · 1 comment
Assignees

Comments

@wouterdb
Copy link
Contributor

wouterdb commented Jan 7, 2025

When we can't figure out the inmanta type, we revert to any

In this case, we want to produce a warning, using the compilers warning framework.
(this will allow us to configure it as failure as well)

@Hugo-Inmanta Hugo-Inmanta self-assigned this Jan 15, 2025
@Hugo-Inmanta
Copy link
Contributor

Hugo-Inmanta commented Jan 15, 2025

Hugo-Inmanta added a commit that referenced this issue Jan 21, 2025
…de. (Issue #8576, PR #8644)

# Description

closes #8576

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci pushed a commit that referenced this issue Jan 21, 2025
…de. (Issue #8576, PR #8666)

# Description

iso7 pr for #8576

- Cherry picks 15b88d1
- Renamed change entry + set destination branch to iso7

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants