Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(YouTube): separate Reset to default part from toasts #1839

Closed
5 tasks done
girshcatt opened this issue Dec 19, 2023 · 3 comments
Closed
5 tasks done

suggestion(YouTube): separate Reset to default part from toasts #1839

girshcatt opened this issue Dec 19, 2023 · 3 comments
Labels
Suggestion Leave any other suggestions

Comments

@girshcatt
Copy link

girshcatt commented Dec 19, 2023

Application

YouTube

Suggestion description

Separate Reset to default part from toasts. Some roms like MiUi have terrible thing, toasts can accommodate only few words. For example on Samsung devices it will look like this:
Custom speeds can't be more than %sx. Reset to default values.
And how on MiUi:
Custom speeds can't be more than %sx...
Do this like main toast will appear at first, and Reset to default values. toast will appear right after it.

List of strings, that contain Reset to default values.
YT:
revanced_custom_playback_speeds_invalid
revanced_custom_playback_speeds_warning
revanced_custom_player_overlay_opacity_warning
revanced_quick_actions_margin_top_warning
YTM:
revanced_custom_filter_strings_warning
revanced_custom_playback_speeds_invalid

revanced_change_start_page_warning, revanced_custom_filter_strings_warning toasts will show all normally in English, but translations for other languages as Russian can have this problem, please separate Resetting to default. part for them

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@girshcatt girshcatt added the Suggestion Leave any other suggestions label Dec 19, 2023
@KobeW50
Copy link
Contributor

KobeW50 commented Jul 15, 2024

Does separating toasts into two lines help with this? Or is the only workaround to have 2 separate toasts?

@girshcatt
Copy link
Author

MiUi/HyperOS cuts the toast after a certain number of characters. So only workaround is to have 2 separate toasts

inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Sep 25, 2024
@inotia00
Copy link
Owner

reflected in revanced-patches-4.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

3 participants