Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: Add in app option to select a preferred language for RVX specific text #2680

Closed
5 tasks done
federicogith opened this issue Jan 16, 2025 · 3 comments
Closed
5 tasks done

suggestion: Add in app option to select a preferred language for RVX specific text #2680

federicogith opened this issue Jan 16, 2025 · 3 comments
Labels
Suggestion Leave any other suggestions

Comments

@federicogith
Copy link

Application

YouTube

Suggestion description

It's not really a feature request as the ReVanced team added it with this PR: ReVanced/revanced-patches#4231

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@federicogith federicogith added the Suggestion Leave any other suggestions label Jan 16, 2025
@inotia00
Copy link
Owner

I already checked this PR, but I don't see any reason to implement this.

Can't you change the app language in App languages ​​in YouTube settings?

@federicogith
Copy link
Author

Can't you change the app language in App languages ​​in YouTube settings?

The PR allows more customisation by having YouTube in one language and the RVX settings and its related text in another language
So like you can use YouTube in a foreign language but still see RVX strings in English

inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jan 17, 2025
@inotia00
feat(YouTube - Settings): Add RVX language setting inotia00/ReVance…
b211df4 
…d_Extended#2680
@inotia00
Copy link
Owner

Reflected in revanced-patches-5.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Suggestion Leave any other suggestions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inotia00 @federicogith