Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protobuf-spoof): support spoofing in feeds too #633

Closed
3 tasks done
WanderBoi opened this issue Apr 2, 2023 · 5 comments
Closed
3 tasks done

feat(protobuf-spoof): support spoofing in feeds too #633

WanderBoi opened this issue Apr 2, 2023 · 5 comments
Labels
Feature request Requesting a new feature

Comments

@WanderBoi
Copy link

Type

Error at runtime

Application

18.13.33

Bug description

Pretty explanatory, videos load for exactly 40 seconds in autoplay then it turns black and endlessly buffer. I tried several methods, protobuf, codec, protocol, each individually, together, paired.

Steps to reproduce

autoplay videos in feed

Relevant log output

sorry not sure how to do this in the extended app

Screenshots or videos

image

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@WanderBoi WanderBoi added the Bug report Something isn't working label Apr 2, 2023
@WanderBoi
Copy link
Author

I have now tried several other versions reaching the same conclusion.

@inotia00
Copy link
Owner

inotia00 commented Apr 2, 2023

In the feed, there is an issue where sound is always output when protobuf spoof is applied

That's why protobuf spoof doesn't apply in feeds.

@inotia00 inotia00 closed this as completed Apr 2, 2023
@WanderBoi
Copy link
Author

any way of having that functionality instead? I'd rather have audio in feed than no autoplay.

@inotia00
Copy link
Owner

inotia00 commented Apr 4, 2023

If so, I will change the label of this patch to patch-request

@inotia00 inotia00 changed the title bug: <videos stop loading and endlessly buffering in autoplay> feat(protobuf-spoof): support spoofing in feeds too Apr 4, 2023
@inotia00 inotia00 added Feature request Requesting a new feature and removed Bug report Something isn't working labels Apr 4, 2023
@inotia00 inotia00 reopened this Apr 4, 2023
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Apr 4, 2023
@inotia00
refactor(protobuf-spoof): add support for protobuf spoofing in feeds i…
609d567 
…notia00/ReVanced_Extended#633
@inotia00
Copy link
Owner

inotia00 commented Apr 4, 2023

reflected in revanced-patches-v2.168.12

@inotia00 inotia00 closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Requesting a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WanderBoi @inotia00