Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube Music): Support patching on Android 5-7 #140

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

kitadai31
Copy link

Support patching on Android 5-7 by adding Files API compatibility

I am not sure of the difference between Files.copy() and Files.write()
Files.write() is used in some part, but when I replaced the it to copy, it's working fine
Do you have any idea why Files.write() is used in some part?

@kitadai31
Copy link
Author

I've not rebased the PR branch after dev.6 has been released, wait a sec please

@kitadai31 kitadai31 force-pushed the music-manager-a5-7-support branch from 8b9a7f6 to e608d6c Compare February 11, 2025 10:02
@inotia00
Copy link
Owner

Do you have any idea why Files.write() is used in some part?

Files.write() is a part that is not modified from the code taken from the ReVanced.

It is not a problem to replace Files.write() with Files.copy().

@inotia00 inotia00 merged commit 967776a into inotia00:dev Feb 12, 2025
@kitadai31 kitadai31 deleted the music-manager-a5-7-support branch February 12, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants