-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube - Searchbar): Restyle #58
feat(YouTube - Searchbar): Restyle #58
Conversation
Can we have a screenshot of how it's going to look? |
to mimic yt instead of "Search settings" as text hint, we could put: "Search {customName}" from the patch options. So the result will be this: "Search ReVanced Extended" or "Search FooBar" (if the user patched with Custom RVX Setting Name = FooBar |
Do you think it's within the scope of this PR to resolve inotia00/ReVanced_Extended#2130? |
I'll work on that request, but I think it is better to divide the work into several steps. otherwise we wait more and more time without releasing anything new. to make the searchbar a different page, I need to study more how android development on views works. so no, this PR will only have the restyle, the custom name in the text hint and the code suggestions that inotia will propose |
#58 (comment) |
done, note that the current translated strings should be updated to match their YouTube language (in order to include the @Rairof in a new PR maybe |
src/main/resources/youtube/settings/layout/revanced_settings_with_toolbar.xml
Show resolved
Hide resolved
src/main/resources/youtube/settings/layout/revanced_settings_with_toolbar.xml
Show resolved
Hide resolved
Since I am not granted access to the PR branch, I will make changes manually after the merge |
ref:
inotia00/revanced-integrations#47