Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Searchbar): Restyle #58

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

Francesco146
Copy link

@ILoveOpenSourceApplications

Can we have a screenshot of how it's going to look?

@Francesco146
Copy link
Author

Here's some screenshots

IMG_20240626_061744_979
IMG_20240626_061741_423
IMG_20240626_061736_668
IMG_20240626_061734_540

@Francesco146
Copy link
Author

to mimic yt instead of "Search settings" as text hint, we could put:

"Search {customName}"

from the patch options. So the result will be this:

"Search ReVanced Extended"

or

"Search FooBar" (if the user patched with Custom RVX Setting Name = FooBar

@ILoveOpenSourceApplications

Do you think it's within the scope of this PR to resolve inotia00/ReVanced_Extended#2130?

@Francesco146
Copy link
Author

I'll work on that request, but I think it is better to divide the work into several steps. otherwise we wait more and more time without releasing anything new. to make the searchbar a different page, I need to study more how android development on views works.

so no, this PR will only have the restyle, the custom name in the text hint and the code suggestions that inotia will propose

@Rairof
Copy link

Rairof commented Jun 26, 2024

#58 (comment)
@Francesco146
it would be nice if you could consider adding the option to customize the pre-text inside the search bar (i.e "Search settings" in your screenshots) within patch option to user's choice similar to how we can change RVX settings name through its patch if it is possible.
I know this sounds similar to your comment in #58 (comment) but I was thinking on giving the users complete customization option on having whatever text in it rather then just being able to change Search(CustomName) in it.

@Francesco146
Copy link
Author

Francesco146 commented Jun 26, 2024

immagine

done, note that the current translated strings should be updated to match their YouTube language (in order to include the %s)


@Rairof in a new PR maybe

@inotia00
Copy link
Owner

Since I am not granted access to the PR branch, I will make changes manually after the merge

@inotia00 inotia00 merged commit f868c54 into inotia00:revanced-extended Jun 27, 2024
@Francesco146 Francesco146 deleted the searchbar-rvx branch July 1, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants