refactor(elements/ino-textarea): migrate stencil e2e tests to spec test #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
|
@BenPag can you resolve the conflicts? |
# Conflicts: # packages/elements/setupSpecTests.ts
janivo
requested changes
Mar 14, 2024
packages/elements/src/components/ino-textarea/ino-textarea.spec.ts
Outdated
Show resolved
Hide resolved
Comment on lines
67
to
73
| it('should set max length property', async () => { | ||
| await checkSettingOfProp('maxLength', '3'); | ||
| }); | ||
|
|
||
| it('should set min length property', async () => { | ||
| await checkSettingOfProp('minLength', '3'); | ||
| }); |
There was a problem hiding this comment.
We could implement these as E2E test.
e.g.:
// given an ino-textarea with max-length=3
await textarea.fill('ABC')
expect(textarea).toBeValid()
await textarea.fill('ABCD')
expect(textarea).not.toBeValid()
// same for min-length
// ...There was a problem hiding this comment.
I cannot test the minlength property. For some reasons the validation is not applied when I wrap the ino-textarea in a form element
janivo
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1258
Proposed Changes