Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Use latest minikube version #108

Merged
merged 25 commits into from
Aug 13, 2020
Merged

Use latest minikube version #108

merged 25 commits into from
Aug 13, 2020

Conversation

maxbischoff
Copy link
Member

@maxbischoff maxbischoff commented Aug 3, 2020 •
edited
Loading

  • update travis.yml
  • document version requirement minikube >= 1.12.1

@johscheuer
Copy link
Contributor

You are probably missing the correct crictl.yaml configuration:

cat /etc/crictl.yaml
runtime-endpoint: unix:///run/containerd/containerd.sock
image-endpoint: unix:///run/containerd/containerd.sock

johscheuer
johscheuer suggested changes Aug 6, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #108 into master will decrease coverage by 12.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #108       +/-   ##
===========================================
- Coverage   50.28%   37.67%   -12.61%     
===========================================
  Files           8       11        +3     
  Lines         885     1327      +442     
  Branches      196      265       +69     
===========================================
+ Hits          445      500       +55     
- Misses        390      775      +385     
- Partials       50       52        +2
Impacted Files Coverage Δ
src/illuminatio/test_orchestrator.py 24.10% <100.00%> (ø)
src/illuminatio/cleaner.py 0.00% <0.00%> (ø)
src/illuminatio/illuminatio.py 0.00% <0.00%> (ø)
src/illuminatio/illuminatio_runner.py 27.91% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ed156...9e37c22. Read the comment docs.

@maxbischoff maxbischoff marked this pull request as ready for review August 11, 2020 11:24
@maxbischoff maxbischoff requested a review from johscheuer August 11, 2020 11:25
johscheuer
johscheuer suggested changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor thinks otherwise LGTM, thanks for tackling this one!

.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
local_dev/run_e2e_tests.sh Outdated Show resolved Hide resolved
local_dev/start_containerd.sh Outdated Show resolved Hide resolved
local_dev/start_containerd.sh Show resolved Hide resolved
local_dev/start_containerd.sh Outdated Show resolved Hide resolved
local_dev/start_docker.sh Outdated Show resolved Hide resolved
@maxbischoff
Copy link
Member Author

Some minor thinks otherwise LGTM, thanks for tackling this one!

Thanks for reviewing, I did a quick self-review beforehand but it obviously was too quick, since I missed even basic stuff such as the debugging commands😅

@maxbischoff maxbischoff requested a review from johscheuer August 12, 2020 07:04
@maxbischoff
Copy link
Member Author

If everything is fine for you I'd like to merge myself, so I can squash some of the unnecessary commits while merging.

johscheuer
johscheuer suggested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing 🙈

local_dev/run_e2e_tests.sh Outdated Show resolved Hide resolved
@maxbischoff @johscheuer
Update local_dev/run_e2e_tests.sh
9e37c22 
Co-authored-by: Johannes Scheuermann <[email protected]>
@maxbischoff maxbischoff requested a review from johscheuer August 12, 2020 07:40
@maxbischoff
Copy link
Member Author

The CI seems to be slightly flaky, sometimes the docker push fails with an EOF error: https://travis-ci.org/github/inovex/illuminatio/jobs/716836038#L1400

The push refers to repository [127.0.0.1:32769/illuminatio-runner]
Get http://127.0.0.1:32769/v2/: EOF

johscheuer
johscheuer approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxbischoff maxbischoff merged commit d571fe1 into inovex:master Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johscheuer johscheuer johscheuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxbischoff @johscheuer