Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tests initial structure | NPG-000 #433

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Jun 15, 2023

Proposing new integration tests structure ispired by rust-lang/cargo#4867
Example:

tests/
       component/
             main.rs
             component1.rs
             component2.rs
      integration/
              main.rs
              component1_component2.rs
      end2end/
             main.rs
             voting.rs       
      non_functional/
                main.rs
                load.rs

In this way we will have 4 crates. Performances could be improved by having only one crate but I think the structure will became to messy
Ideas welcome @nicopado @stevenj

@kukkok3 kukkok3 added the draft Draft label Jun 15, 2023
@kukkok3 kukkok3 requested review from stevenj and nicopado June 15, 2023 20:07
@kukkok3 kukkok3 self-assigned this Jun 15, 2023
Copy link
Contributor

@nicopado nicopado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicopado nicopado changed the title feat: Tests initial structure|NPG-000 feat: Tests initial structure | NPG-000 Jun 16, 2023
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicopado nicopado marked this pull request as ready for review June 19, 2023 08:15
@nicopado nicopado enabled auto-merge June 19, 2023 08:57
@nicopado nicopado merged commit 653ad27 into main Jun 19, 2023
@nicopado nicopado deleted the tests-initial-structure branch June 19, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants