Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file extensions from .md.erb to .md #252

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok [email protected]

Description

  • Update some typo in docs
  • Rename tag to tags in azurerm_mysql_servers
  • Update data_disks property of azurerm_virtual_machines to align with the documentation
  • Update integration test

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

- Update some typo in docs
- Rename `tag` to `tags` in azurerm_mysql_servers
- Update `data_disks` property of azurerm_virtual_machines to align with the documentation
- Update integration test

Signed-off-by: Omer Demirok <[email protected]>
@omerdemirok omerdemirok requested a review from a team June 17, 2020 16:46
This is due to not updating integration tests after this change:
e4cc8e1

Signed-off-by: Omer Demirok <[email protected]>
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerdemirok

@skpaterson skpaterson merged commit 74210fa into master Jun 18, 2020
@skpaterson skpaterson deleted the docs_extension_update branch June 18, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants