-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new backend class #277
Conversation
- Standalone base class (do not require SDK or plug-in) - Add generic resources enabling to test any Azure resource - Provide server side filtering via generic resources - Support working with different api versions and endpoints - Rewrite some of the static resources fully backward compatible Signed-off-by: Omer Demirok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the .env
file be included in this PR?
Signed-off-by: Omer Demirok <[email protected]>
Signed-off-by: Omer Demirok <[email protected]>
Signed-off-by: Omer Demirok <[email protected]>
Signed-off-by: Ross Moles <[email protected]>
Signed-off-by: Omer Demirok <[email protected]>
…ure into azure_generic_resources
Signed-off-by: Ross Moles <[email protected]>
Removed it. |
Signed-off-by: Omer Demirok <[email protected]>
…ure into azure_generic_resources
Signed-off-by: Omer Demirok <[email protected]>
Thanks for this excellent catch, @NathanPrado. Fixing this unearthed some other issues as well. |
I really appreciate your effort, thank for looking into that. Glad to kill off more bugs. I tried pulling down the latest of this branch locally and referencing it in my tests but got this error now
Am I missing a step? Please let me know what I can do to help! |
@NathanPrado |
Signed-off-by: Omer Demirok <[email protected]>
Signed-off-by: Omer Demirok <[email protected]>
Signed-off-by: Omer Demirok <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic work @omerdemirok !!
Signed-off-by: Omer Demirok <[email protected]>
…ure into azure_generic_resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @omerdemirok! This is a great improvement on the Azure resource pack.
Signed-off-by: Omer Demirok <[email protected]>
Signed-off-by: Ross Moles <[email protected]>
@omerdemirok - Can we use |
@Sum123it, you should be able to use it if you point the depends to the version |
Signed-off-by: Omer Demirok [email protected]
Description
For more info, see project README.
Issues Resolved
Fixes #262, #249, #205
Check List
rake lint
passes