Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write more resources with the new backend #286

Merged
merged 9 commits into from
Aug 28, 2020
Merged

Re-write more resources with the new backend #286

merged 9 commits into from
Aug 28, 2020

Conversation

omerdemirok
Copy link
Contributor

@omerdemirok omerdemirok commented Aug 27, 2020 •
edited
Loading

Signed-off-by: Omer Demirok [email protected]

Description

README

  • Update with the new resources

OLD DOCS

  • Add depreciation message

NEW DOCS

  • Add docs for the new resources
  • Fix some typos in the previously created ones

BACKEND

  • Add to_s method to AzureResourceProbe
  • Delete to_s method of NullResponse to prevent possible confusion
  • Handle resource aggregation in AzureGenericResources and simplify plural static resources

Issues Resolved

N/A

Check List

Omer Demirok added 4 commits August 25, 2020 18:08
@omerdemirok omerdemirok requested a review from a team as a code owner August 27, 2020 14:41
rmoles
rmoles reviewed Aug 28, 2020
View reviewed changes
libraries/azure_backend.rb Outdated Show resolved Hide resolved
Fix some typos
80a56d9 
Signed-off-by: Omer Demirok <[email protected]>
rmoles
rmoles approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @omerdemirok. Looks good to me 💯

@omerdemirok omerdemirok added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Aug 28, 2020
@rmoles rmoles merged commit 8a1e94c into inspec:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerdemirok @rmoles