Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AzureSubscription#locations fully backward compatible #315

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Make AzureSubscription#locations fully backward compatible #315

merged 3 commits into from
Oct 2, 2020

Conversation

omerdemirok
Copy link
Contributor

Signed-off-by: Omer Demirok [email protected]

Description

  • Make AzureSubscription#locations fully backward compatible by filtering the more comprehensive location lists returning from the latest API
  • Add new methods to provide processed information about the locations for the subscription

Issues Resolved

Fixes #313

Check List

@omerdemirok omerdemirok requested a review from a team as a code owner October 1, 2020 14:48
@gsreynolds
Copy link
Contributor

Awesome. Thanks @omerdemirok ❤️

rmoles
rmoles approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omerdemirok good work 💯

skpaterson
skpaterson approved these changes Oct 2, 2020
View reviewed changes
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @omerdemirok

@skpaterson skpaterson added the Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number. label Oct 2, 2020
@rmoles rmoles merged commit 6b45195 into master Oct 2, 2020
@rmoles rmoles deleted the locations_on_subscription branch October 2, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

@skpaterson skpaterson skpaterson approved these changes

Assignees
No one assigned
Labels
Version: Bump Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure_subscription locations API 2020-01-01 returns physical and logical locations
4 participants
@omerdemirok @gsreynolds @rmoles @skpaterson