Adding subscription level check for diagnostic settings #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe McCrea <[email protected]>
Signed-off-by: Joe McCrea <[email protected]>
voojoe
changed the title
rmoles
reviewed
Oct 8, 2020
libraries/azure_subscription.rb
Outdated
| return nil if diagnostic_settings.first.nil? | ||
| result = [] | ||
| diagnostic_settings.each do |setting| | ||
| result += setting.properties.logs.reject(&:enabled).map(&:category) |
There was a problem hiding this comment.
it's perhaps worthwhile to use the ruby safe navigator in each of these methods, in case there is a scenario where one of the values does not exist.
result += setting.properties&.logs&.reject(&:enabled)&.map(&:category)
There was a problem hiding this comment.
Hey @rmoles thanks for the suggestion, I've pushed that now
Signed-off-by: Joe McCrea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding in a number of new attributes for the azure_subscription resource in order to allow checks for configuration of the diagnostic settings.
Issues Resolved
#321
Check List
rake lintpasses