Require Ruby 2.3+ / InSpec 1.47+ and update dev deps #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use expeditor now Signed-off-by: Tim Smith <[email protected]>
This does nothing, but break things on bundler 2.x Signed-off-by: Tim Smith <[email protected]>
Remove support for EOL Ruby Signed-off-by: Tim Smith <[email protected]>
We're not using this anymore. Stop carrying around the baggage. Signed-off-by: Tim Smith <[email protected]>
Bring our deps up to date. Signed-off-by: Tim Smith <[email protected]>
No one likes hidden files. Signed-off-by: Tim Smith <[email protected]>
Since we ship kitchen-inspec in DK for 99.9% of users they already have a fully up-to-date InSpec. This just allows us to remove a conditional and a test. Signed-off-by: Tim Smith <[email protected]>
tas50
changed the title
Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
We need these gems for testing in Travis Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Tim Smith <[email protected]>
The extra `|` was catching everything Signed-off-by: Tim Smith <[email protected]>
Also disable sudo since they ignore this config now. Signed-off-by: Tim Smith <[email protected]>
Make sure we test on everything we support Signed-off-by: Tim Smith <[email protected]>
| @@ -134,13 +134,13 @@ | |||
|
|
|||
| - \[QUESTION\] kitchen-inspec formatter [\#147](https://github.com/inspec/kitchen-inspec/issues/147) | |||
| - Executing inspec against a container from within the host [\#145](https://github.com/inspec/kitchen-inspec/issues/145) | |||
| - Option to specify path to Inspec test with kitchen-inspec [\#139](https://github.com/inspec/kitchen-inspec/issues/139) | |||
| - Option to specify path to InSpec test with kitchen-inspec [\#139](https://github.com/inspec/kitchen-inspec/issues/139) | |||
There was a problem hiding this comment.
I ❤️you so much for these changes.
There was a problem hiding this comment.
I worked for a company that changed the case of their name to be all lowercase (so cool). I spent years slowly fixing it all.
jerryaldrichiii
approved these changes
Jan 23, 2019
miah
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require a supported Ruby release and bump all the deps to current.