Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gemspec dependencies for InSpec AWS #23

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Update gemspec dependencies for InSpec AWS #23

merged 1 commit into from
Jul 3, 2019

Conversation

rmoles
Copy link

@rmoles rmoles commented Jul 3, 2019 •
edited
Loading

Description

Based on the previous discussion, we have un-commented dependencies required for inspec-aws resource pack for the near future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Ross Moles [email protected]

skpaterson
skpaterson approved these changes Jul 3, 2019
View reviewed changes
Copy link

@skpaterson skpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmoles ! @tas50 - this list can be trimmed down a bit if needs must.

@zenspider
Copy link
Contributor

Fantastic. Thank you. I will confer with @tas50 to see how this feels on an actual build.

miah
miah approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you =)

zenspider
zenspider approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@zenspider zenspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zenspider zenspider merged commit 89b71dd into master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skpaterson skpaterson skpaterson approved these changes

@miah miah miah approved these changes

@zenspider zenspider zenspider approved these changes

@clintoncwolfe clintoncwolfe Awaiting requested review from clintoncwolfe

@dmurray-chef dmurray-chef Awaiting requested review from dmurray-chef

@tas50 tas50 Awaiting requested review from tas50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rmoles @zenspider @miah @skpaterson