Move train dependency to Gemfile from gemspec #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clinton Wolfe <[email protected]>
clintoncwolfe
force-pushed
the
cw/move-train-dep-to-gemfile
branch
from
ebf4346 to
7e5b9a0
Compare
|
I thought I approved this last week? |
zenspider
approved these changes
Aug 14, 2019
clintoncwolfe
added
the
Aspect: Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Clinton Wolfe [email protected]
Description
This moves the dependencies on train into the Gemfile; without this, all train plugins must agree on train constraints for the inspec package when we ship it.
Also increments the allowed upper version to < 4; v3 has no changes that break this plugin.
Related Issue
Types of changes
Checklist: