Fix conservative dependencies to have proper "x.y" values #30
Conversation
|
Absolutely... The diff centers around my having done this the first time around incorrectly. All of the dependencies (almost all comments at this point) were written with |
zenspider
changed the title
| @@ -29,6 +29,21 @@ namespace :test do | |||
| end | |||
| end | |||
|
|
|||
| task :deps do | |||
There was a problem hiding this comment.
Would be nice to add a desc string to explain what this task does and also to have it appear in the rake -T task list
| @@ -29,6 +29,21 @@ namespace :test do | |||
| end | |||
| end | |||
|
|
|||
| task :deps do | |||
| src = `curl -sL https://github.com/inspec/inspec-aws/archive/master.tar.gz | tar xO inspec-aws-master/Gemfile` | |||
There was a problem hiding this comment.
This task isn't going to be usable by Windows users. Since the task is informational and not critical to using the plugin, that's probably OK.
| # spec.add_dependency "aws-sdk-appstream", "~> 1" | ||
| # spec.add_dependency "aws-sdk-appsync", "~> 1" | ||
| spec.add_dependency "aws-sdk-athena", "~> 1" | ||
| # spec.add_dependency "aws-sdk-acm", "~> 1.0" |
|
Dep changes look good to me but I'm not familiar with the AWS gems so adding @inspec/inspec-cloud-devs as a reviewer. While this change is a valid correction, I don't know what other projects might be depending on a version being >= 2.0 |
zenspider
force-pushed
the
zenspider/more-dep-stuff
branch
from
6c1fea5 to
629b650
Compare
I don't think it works the way they think it works... Signed-off-by: Ryan Davis <[email protected]>
Prints out missing and (possibly) extra dependencies. Signed-off-by: Ryan Davis <[email protected]>
zenspider
force-pushed
the
zenspider/more-dep-stuff
branch
from
629b650 to
9d15496
Compare
Signed-off-by: Ryan Davis <[email protected]>
Signed-off-by: Ryan Davis <[email protected]>
More followup to previous dependency problems.