add guardduty dependency #62
Conversation
Signed-off-by: Sam Scott <[email protected]>
train-aws.gemspec
Outdated
| @@ -117,7 +117,7 @@ Gem::Specification.new do |spec| | |||
| # spec.add_dependency "aws-sdk-glue", "~> 1.0" | |||
| # spec.add_dependency "aws-sdk-greengrass", "~> 1.0" | |||
| # spec.add_dependency "aws-sdk-groundstation", "~> 1.0" | |||
| # spec.add_dependency "aws-sdk-guardduty", "~> 1.0" | |||
| spec.add_dependency "aws-sdk-guardduty", "~> 1.0" | |||
There was a problem hiding this comment.
I see the newest version of guardduty is at 1.31. Should we consider updating this to the latest?
Thoughts @skpaterson @samscottchef ?
There was a problem hiding this comment.
Seems worthwhile to me
There was a problem hiding this comment.
@samscottchef this looks good/reasonable enough to me 😄
Whenever we add/bump dependencies I usually ping @inspec/foundation-team-reviewers for a day to ensure we're not missing any knowledge i.e. "we can't add this dependency because x"! - So unless they raise something by tomorrow happy to approve.
Do concur with @rmoles about using 1.31 if possible 👍
Signed-off-by: Sam Scott <[email protected]>
|
Latest commit updated to 1.31 |
|
(and by "me" I mean someone who's actually authorized to merge on this PR 😂 , probably @rmoles ) |
Signed-off-by: Sam Scott [email protected]
uncommented the GuardDuty add dependency
Description
I need the GuardDuty gem for adding a new resource in InSpec AWS
Types of changes
Checklist: