Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS Shield SDK #68

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Add AWS Shield SDK #68

merged 1 commit into from
Jan 25, 2021

Conversation

samscottchef
Copy link
Contributor

Signed-off-by: Sam Scott [email protected]

AWS Shield needed for upcoming resource.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

rmoles
rmoles approved these changes Nov 19, 2020
View reviewed changes
Copy link

@rmoles rmoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Schwad
Copy link

Schwad commented Nov 20, 2020

LGTM - I don't have merge authority on train-aws btw. :)

@clintoncwolfe clintoncwolfe merged commit f60f661 into master Jan 25, 2021
@clintoncwolfe clintoncwolfe deleted the aws_shield_sdk branch January 25, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmoles rmoles rmoles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samscottchef @Schwad @rmoles @clintoncwolfe