Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating expeditor configuration #62

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

jayashrig158
Copy link
Contributor

Signed-off-by: jayashri garud [email protected]

Description

i) The merge_actions subscription shortcut has been deprecated. All subscriptions should be declared via the subscriptions block for clarity.
ii) Release branches are a first-class concept in Expeditor, and should be represented as such.
iii) The promote block has been deprecated. All actions should be declared via the subscriptions block for clarity.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@jayashrig158 jayashrig158 added the Expeditor: Skip All CI/CD: Don't do anything on merge label Jun 29, 2021
@jayashrig158 jayashrig158 self-assigned this Jun 29, 2021
@jayashrig158 jayashrig158 requested a review from tduffield June 29, 2021 08:46
actions:
- built_in:rollover_changelog
- built_in:publish_rubygems
subscriptions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be one subscriptions block — this needs to be combined with the one below.

@jayashrig158 jayashrig158 force-pushed the jgarud/update-expeditor-configuration branch from 0e5bfec to 4544772 Compare June 30, 2021 07:43
@jayashrig158 jayashrig158 requested a review from tduffield June 30, 2021 07:43
- master

release_branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation to be only 2 spaces.

Signed-off-by: jayashri garud <[email protected]>
@jayashrig158 jayashrig158 force-pushed the jgarud/update-expeditor-configuration branch from e0dccd8 to a6d54da Compare July 1, 2021 05:52
@jayashrig158 jayashrig158 requested a review from tduffield July 1, 2021 05:55
@tduffield tduffield merged commit 22a7879 into master Jul 1, 2021
@tduffield tduffield deleted the jgarud/update-expeditor-configuration branch July 1, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Skip All CI/CD: Don't do anything on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants