Updating for rexml cve inclusiong #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Signed-off-by: John McCrae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Train-Winrm relies on winrm and related gems that currently include an older version of rexml that has a CVE in it. Chef Infra has updated winrm, winrm-fs, and winrm-elevated. We had to fork these codebases and have released chef-winrm, chef-winrm-fs, and chef-winrm-elevated. They are functionally identical to their counterparts but have the version, name and rexml updated. We need that code included here to reduce confusion and risk.
Related Issue
Types of changes
Checklist: