Allow requesting a PTY #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the user to request a pseudo-tty:
```
require 'train'
t = Train.create('ssh', host: '127.0.0.1', port: '2200', user: 'vagrant', password: 'vagrant', sudo: true, pty: true);
puts t.connection.run_command("ls /")
```
While this allows passing the `requiretty` sudoer defaults of certain
RedHat-ish distributions, it comes at the cost of having stderr and
stdout merged together. The change includes a warning for this.
The command above, for example, outputs:
```
<struct Train::Extras::CommandResult stdout="/etc/profile.d/lang.sh: line 19: warning: setlocale: LC_CTYPE: cannot change locale (UTF-8): No such file or directory\r\nbin dev home lib64\tmnt proc run\t shared sys usr var\r\nboot etc lib\t media\topt root sbin srv\t tmp vagrant\r\n", stderr="", exit_status=0>
```
For comparison, this is the output _without_ the PTY:
```
<struct Train::Extras::CommandResult stdout="bin\nboot\ndev\netc\nhome\nlib\nlib64\nmedia\nmnt\nopt\nproc\nroot\nrun\nsbin\nshared\nsrv\nsys\ntmp\nusr\nvagrant\nvar\n", stderr="/etc/profile.d/lang.sh: line 19: warning: setlocale: LC_CTYPE: cannot change locale (UTF-8): No such file or directory\n", exit_status=0>
```
Note how `ls` behaves differently -- in the presence of a PTY, it will
prettify its output.
srenatus
force-pushed
the
BP-202/allow_requiring_a_pty
branch
from
f7cff6d to
3d67a43
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to request a pseudo-tty:
While this allows passing the
requirettysudoer defaults of certainRedHat-ish distributions, it comes at the cost of having stderr and
stdout merged together. The change includes a warning for this.
The command above, for example, outputs:
For comparison, this is the output without the PTY:
Note how
lsbehaves differently -- in the presence of a PTY, it willprettify its output.
Fixes #60.
This is still not a fix for InSpec failing with the
requirettyissue, since the merging ofstd{err,out}will probably break most profiles and resources relying on the distinction. However, for users using train for remote execution, that do not that strongly depend on it, it's a necessary feature.