support empty URIs #154
Merged
support empty URIs #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome, it's failing! time to fix it :) I think we should continue to support these URIs for the simple reason that writing and printing it consistenly works so well, i.e. if we run with mock backend only, we print out which users can use to configure the system again. Other solutions would involve setting the hostname, e.g.: which would be ignored (and may change in the future?). This convolutes the target with confusing information; |
arlimus
force-pushed
the
dr/empty-uri
branch
2 times, most recently
from
a4d8e63 to
103ff43
Compare
see a failures like [this](https://travis-ci.org/dev-sec/tests-ssh-hardening/jobs/167860903) which start appearing
|
+1 |
clintoncwolfe
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see a failures like this which start appearing