Platform framework and detect DSL #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquick
force-pushed
the
jq/platform_objects
branch
2 times, most recently
from
c0303a5 to
f9319d5
Compare
Signed-off-by: Jared Quick <[email protected]>
jquick
force-pushed
the
jq/platform_objects
branch
from
f9319d5 to
02441ef
Compare
adamleff
reviewed
Nov 15, 2017
lib/train/transports/mock.rb
Outdated
| @@ -77,8 +74,20 @@ def mock_os(value = {}) | |||
| # if a user passes a nil value, set to an empty hash so the merge still succeeds | |||
| value ||= {} | |||
|
|
|||
| os_params = { name: 'unknown', family: 'unknown', release: 'unknown', arch: 'unknown' }.merge(value) | |||
There was a problem hiding this comment.
Hey @jquick! We need to ensure mock_os still allows other callers to set the release and arch, and we also need to make sure they're not nil. Can you check to see if you account for this, and if not, could you push up a commit that adds that functionality back?
This will potentially break only_if evaluation during inspec check calls as well as some unit tests potentially (though I think everything in InSpec's unit tests are focused on name and family only).
Signed-off-by: Jared Quick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the detect logic for platforms into a new framework. You can create platforms on the fly using the new platform DSL.
Signed-off-by: Jared Quick [email protected]