Use the sanitized file path for remote linux files #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had a test start failing recently and tracked it down to remote linux file resources no longer handling spaces in paths as of the refactor in 0.29.0. The test passes again after applying this change. Signed-off-by: Jonathan Hartman <[email protected]>
adamleff
approved these changes
Nov 20, 2017
There was a problem hiding this comment.
That's a great catch, @RoboticCheese - thanks for your first PR to Train, and thanks for your submission.
chris-rock
approved these changes
Nov 20, 2017
adamleff
pushed a commit
that referenced
this pull request
Nov 21, 2017
Had a test start failing recently and tracked it down to remote linux file resources no longer handling spaces in paths as of the refactor in 0.29.0. The test passes again after applying this change. Signed-off-by: Jonathan Hartman <[email protected]>
chris-rock
pushed a commit
that referenced
this pull request
Nov 21, 2017
* Add unix_mode_mask method to Train::File::Local::Unix (#215) * Add unix_mode_mask method to Train::File::Local::Unix During the refactor, the `#unix_mode_mask` method for Unix files was only added to the Remote class. It's still needed for the Local class. Signed-off-by: Adam Leff <[email protected]> * Use the sanitized file path for remote linux files (#218) Had a test start failing recently and tracked it down to remote linux file resources no longer handling spaces in paths as of the refactor in 0.29.0. The test passes again after applying this change. Signed-off-by: Jonathan Hartman <[email protected]> * Adding branches for testing Signed-off-by: Adam Leff <[email protected]> * Remove bundler install during Appveyor tests (#217) It appears that the Appveyor images changed recently and the Ruby installs for all version (2.2, 2.3, and 2.4) already include Bundler installed. Attempting to install it will hang the tests at an interactive prompt asking if you want to override the install, and --force'ing the install causes path issues and Rubygems won't be able to activate the gem. Removing the bundler install appears to solve the problem nicely. Signed-off-by: Adam Leff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a test start failing recently and tracked it down to remote linux file
resources no longer handling spaces in paths as of the refactor in 0.29.0.
The test passes again after applying this change.
Signed-off-by: Jonathan Hartman [email protected]