Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco nexus + ios12 #247

Merged
merged 5 commits into from
Feb 1, 2018
Merged

cisco nexus + ios12 #247

merged 5 commits into from
Feb 1, 2018

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jan 31, 2018

No description provided.

@arlimus arlimus requested a review from a team January 31, 2018 22:52
for now...

Signed-off-by: Dominik Richter <[email protected]>
@arlimus arlimus changed the title cisco nexus cisco nexus + ios12 Jan 31, 2018
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'd be even happier with some unit tests. :)

@arlimus
Copy link
Contributor Author

arlimus commented Jan 31, 2018

Good point, let's hold off until I add some too. Thank you!!

Signed-off-by: Dominik Richter <[email protected]>
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arlimus for this improvement

@chris-rock chris-rock merged commit 16278f7 into master Feb 1, 2018
@chris-rock chris-rock deleted the dom/cisco-nexus branch February 1, 2018 10:48
jerryaldrichiii pushed a commit that referenced this pull request Feb 5, 2018
* avoid false detection of IOS12

due to missing exit status

* detect cisco ios12

* support cisco nexus family detection

tested on v5.2 Nexus5010

* set arch to nil on cisco devices

for now...

Signed-off-by: Dominik Richter <[email protected]>

* add unit tests

Signed-off-by: Dominik Richter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants