-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cisco nexus + ios12 #247
cisco nexus + ios12 #247
Conversation
due to missing exit status
tested on v5.2 Nexus5010
for now... Signed-off-by: Dominik Richter <[email protected]>
c09e842
to
a01b860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I'd be even happier with some unit tests. :)
Good point, let's hold off until I add some too. Thank you!! |
Signed-off-by: Dominik Richter <[email protected]>
b93cbb8
to
1b9aa56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @arlimus for this improvement
* avoid false detection of IOS12 due to missing exit status * detect cisco ios12 * support cisco nexus family detection tested on v5.2 Nexus5010 * set arch to nil on cisco devices for now... Signed-off-by: Dominik Richter <[email protected]> * add unit tests Signed-off-by: Dominik Richter <[email protected]>
No description provided.