Update errors to have a base type of Train::Error #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inherits from StandardError. This simplifies integrating this library, allowing the caller to implement common Train error handling without having to be updated when new error types are added to the gem. Signed-off-by: Marc A. Paradise <[email protected]>
marcparadise
force-pushed
the
mp/common-error-base
branch
from
2a4b686 to
efc1613
Compare
jquick
approved these changes
Mar 23, 2018
jerryaldrichiii
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Train::Error inherits from StandardError.
This simplifies integrating this library, allowing the caller to
implement common Train error handling without having to be updated
when new error types are added to the gem.
Signed-off-by: Marc A. Paradise [email protected]