Retry SSH command on IOError (Cisco IOS specific) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryaldrichiii
force-pushed
the
ja/cisco-ios-race-condition
branch
2 times, most recently
from
08f7981 to
a74b468
Compare
Cisco IOS occasionally closes the SSH stream prematurely while we are running commands to detect if we need to switch to the Cisco IOS transport. This retries the SSH command if this is the case. Signed-off-by: Jerry Aldrich <[email protected]>
jerryaldrichiii
force-pushed
the
ja/cisco-ios-race-condition
branch
from
a74b468 to
5eb0f68
Compare
jquick
approved these changes
Jul 26, 2018
There was a problem hiding this comment.
Thanks @jerryaldrichiii. We should probably add a test for this but we can do that in another PR due to the rush on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cisco IOS occasionally closes the SSH stream prematurely while we are running commands to detect if we need to switch to the Cisco IOS transport.
This retries the SSH command if this is the case.