Replace the usage of const_defined? in the WinRM detection helper #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.6.1 came with some [changes](ruby/ruby#2061) to `const_defined?` that now have it evaluating as true from this helper method, matching the behavior of `const_get`, even though the constant is inaccessible by name. This results in an exception bubbling up from the `winrm?` method: ``` ✗ bundle exec kitchen verify default-amazonlinux-2-chef-14 -----> Starting Kitchen (v1.24.0) -----> Verifying <default-amazonlinux-2-chef-14>... >>>>>> ------Exception------- >>>>>> Class: Kitchen::ActionFailed >>>>>> Message: 1 actions failed. >>>>>> Failed to complete #verify action: [uninitialized constant Train::Transports::WinRM] on default-amazonlinux-2-chef-14 ``` A quick way around it is to make this backend comparison match the one [here](https://github.com/inspec/train/blob/v1.7.2/lib/train/platforms/detect/specifications/os.rb#L24). Signed-off-by: Jonathan Hartman <[email protected]>
|
For the record, I'm a little unclear on what's going on in Inspec/Train's requires/includes to result in this. If it looks more like a Ruby bug to y'all, please disregard. I started here after discovering that |
|
Kitchen reports this as I applied @RoboticCheese's PR manually to the installed gem and the issue goes away. |
michaelklishin
added a commit
to rabbitmq/chef-cookbook
that referenced
this pull request
Mar 4, 2019
Commited while investigating what ended up being a Train bug specific to Ruby 2.6 [1]. No harm in keeping it around. 1. inspec/train#406
michaelklishin
added a commit
to rabbitmq/chef-cookbook
that referenced
this pull request
Mar 4, 2019
|
Hit this same exact issue the other day. Would be great to see this merged if possible |
|
@clintoncwolfe really sorry to bother you directly but Test Kitchen is unusable on Ruby 2.6 due to the above issue. Any chance this PR or some alternative solution can get some attention soon? Thank you 🙏 |
clintoncwolfe
approved these changes
Mar 13, 2019
marcparadise
pushed a commit
to marcparadise/train
that referenced
this pull request
Mar 18, 2019
…spec#406) Ruby 2.6.1 came with some [changes](ruby/ruby#2061) to `const_defined?` that now have it evaluating as true from this helper method, matching the behavior of `const_get`, even though the constant is inaccessible by name. This results in an exception bubbling up from the `winrm?` method: ``` ✗ bundle exec kitchen verify default-amazonlinux-2-chef-14 -----> Starting Kitchen (v1.24.0) -----> Verifying <default-amazonlinux-2-chef-14>... >>>>>> ------Exception------- >>>>>> Class: Kitchen::ActionFailed >>>>>> Message: 1 actions failed. >>>>>> Failed to complete #verify action: [uninitialized constant Train::Transports::WinRM] on default-amazonlinux-2-chef-14 ``` A quick way around it is to make this backend comparison match the one [here](https://github.com/inspec/train/blob/v1.7.2/lib/train/platforms/detect/specifications/os.rb#L24). Signed-off-by: Jonathan Hartman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.6.1 came with some changes to
const_defined?that now have it evaluating as true from this helper method, matching the behavior ofconst_get, even though the constant is inaccessible by name. This results in an exception bubbling up from thewinrm?method:A quick way around it is to make this backend comparison match the one here.
Signed-off-by: Jonathan Hartman [email protected]