[SUSTAIN-955] Add kerberos and additional winrm options #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with knife bootstrap's conversion to train, this PR adds kerberos as a supported protocol, and includes the additional kerberos options kerberos_realm, kerberos_service This also adds 'ssl_peer_fingerprint' and 'ca_trust_file' support. Signed-off-by: Marc A. Paradise <[email protected]>
marcparadise
changed the title
marcparadise
commented
Mar 18, 2019
| @@ -124,6 +126,10 @@ def connection_options(opts) | |||
| connection_retry_sleep: opts[:connection_retry_sleep], | |||
| max_wait_until_ready: opts[:max_wait_until_ready], | |||
| no_ssl_peer_verification: opts[:self_signed], | |||
| realm: opts[:kerberos_realm], | |||
clintoncwolfe
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Thanks! If you could take some notes on how your setup your VM for manual testing on #419, that would be awesome!
|
@marcparadise Awesome work on adding the kerberos transport also. ❤️ |
marcparadise
added a commit
to marcparadise/train
that referenced
this pull request
Apr 19, 2019
For compatibility with knife bootstrap's conversion to train, this PR adds kerberos as a supported protocol, and includes the additional kerberos options kerberos_realm, kerberos_service This also adds 'ssl_peer_fingerprint' and 'ca_trust_file' support. Signed-off-by: Marc A. Paradise <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility with knife bootstrap's conversion to train,
this PR adds kerberos as a supported protocol, and includes the
additional kerberos options kerberos_realm, kerberos_service
This also adds 'ssl_peer_fingerprint' and 'ca_trust_file' support.
Signed-off-by: Marc A. Paradise [email protected]