Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using global expectation methods and switch to using _. #524

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Stop using global expectation methods and switch to using _. #524

merged 1 commit into from
Oct 17, 2019

Conversation

zenspider
Copy link
Contributor

Fixes new deprecations from minitest 5.12+ and cleans the test output
back to plain dots.

Signed-off-by: Ryan Davis [email protected]

@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Oct 8, 2019

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@zenspider zenspider self-assigned this Oct 8, 2019
@zenspider zenspider requested review from tas50 and miah October 8, 2019 21:58
@zenspider zenspider added Aspect/Testing Type: Chore How can you have any pudding if you don't eat your meat? labels Oct 8, 2019
@zenspider
Stop using global expectation methods and switch to using _.
bc3a18b 
Fixes new deprecations from minitest 5.12+ and cleans the test output
back to plain dots.

Signed-off-by: Ryan Davis <[email protected]>
@zenspider zenspider force-pushed the zenspider/minitest_5.12 branch from 5533a9b to bc3a18b Compare October 9, 2019 20:23
@codeclimate
Copy link

codeclimate bot commented Oct 9, 2019

Code Climate has analyzed commit bc3a18b and detected 0 issues on this pull request.

View more on Code Climate.

@zenspider zenspider merged commit 6922b4c into master Oct 17, 2019
@chef-expeditor chef-expeditor bot deleted the zenspider/minitest_5.12 branch October 17, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@tas50 tas50 Awaiting requested review from tas50

Assignees

@zenspider zenspider

Labels
Aspect: Testing Type: Chore How can you have any pudding if you don't eat your meat?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenspider @miah