Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overriding follow_symlink on Train::File #550

Merged
merged 1 commit into from
Dec 31, 2019
Merged

allow overriding follow_symlink on Train::File #550

merged 1 commit into from
Dec 31, 2019

Conversation

miah
Copy link
Contributor

@miah miah commented Dec 31, 2019

The File resource in InSpec the symlink related options isn't working right because follow_symlink is always true.

Consider..

module Train
  class File
    def initialize(backend, path, follow_symlink = true)
    end
  end
end

The remote file resources in train were not allowing this to be set.

Related inspec/inspec#3876

@miah miah requested a review from a team as a code owner December 31, 2019 01:20
@chef-expeditor
Copy link
Contributor

Hello miah! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@ghost ghost requested review from clintoncwolfe and zenspider December 31, 2019 01:20
Consider..

module Train
  class File
    def initialize(backend, path, follow_symlink = true)
    end
  end
end

Signed-off-by: Miah Johnson <[email protected]>
@miah miah merged commit cd6ca89 into master Dec 31, 2019
@chef-expeditor chef-expeditor bot deleted the mj/file_args branch December 31, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants