Attempt to fix --sudo.

[skpaterson]

Signed-off-by: Stuart Paterson [email protected]

EDIT: this is a proposed fix for inspec/inspec#4826

[chef-expeditor]

Hello skpaterson! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes
   a. If everything looks good, one of them will approve it, and your PR will be merged.
   b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
   c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

[tas50]

We'll want to test this with Chef Infra bootstrapping too since it's using the same code I believe.

[clintoncwolfe]

I've performed manual testing against an ubuntu 16.04 vagrant box, and this worked well.

I'm now going to test a freebsd11 machine.

Works on freebsd11 with the caveat that base64 needs to be installed (see #445)

Now testing knife bootstrap.

@mp and I tested it with knife bootstrap and verified the fix (fixes chef/chef#9404)

[clintoncwolfe]

After working with this a bit and discussing with @mp, we noted that running run(-h) (which would typically expand to sh -c sudo -h would only verify that you had sudo (or your alternate sudo command) installed and that it accepted the -h (likely usage help) option. That's a semantic change from the previous -v, which would cause it to validate the credentials.

I've now tried it with run(echo) - basically "portably do nothing and succeed" on ubuntu16, freebsd11 on inspec, and both of those using knife bootstrap. That seems to work well.