Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DragonflyBSD detection #614

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

thheinen
Copy link
Contributor

Description

This brings platform detection up to par with Ohai, as DragonFly is the only BSD missing in Train.

Related Issue

As it's a one-liner without side effects, I suppose an own issue is overkill?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Thomas Heinen <[email protected]>
@thheinen thheinen requested a review from a team as a code owner June 18, 2020 09:18
@thheinen thheinen requested review from clintoncwolfe and Schwad June 18, 2020 09:18
@chef-expeditor
Copy link
Contributor

Hello tecracer-theinen! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Copy link

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tecracer-theinen - thanks for submitting this. It looks good to me (I know we don't have any declare_bsd/declare_instance tests yet generally).

I will hold on merging on this specifically until we get a second set of core team eyes on this PR and resolve a current release issue we're working through.

Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tas50 tas50 merged commit 73ec766 into inspec:master Jun 18, 2020
@tas50
Copy link
Contributor

tas50 commented Jun 18, 2020

Thanks @tecracer-theinen

@thheinen thheinen deleted the theinen/dragonfly-detection branch June 22, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants