Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the old integration tests closer to running #620

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 8, 2020

I think the idea here is probably right. We just need to get them running in Buildkite again. This is step 1 of many.

Signed-off-by: Tim Smith [email protected]

I think the idea here is probably right. We just need to get them running in Buildkite again. This is step 1 of many.

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 requested a review from a team as a code owner July 8, 2020 16:42
@tas50 tas50 requested review from Schwad and james-stocks July 8, 2020 16:42
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Jul 8, 2020

Hello tas50! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@tas50 tas50 merged commit 8daef3b into master Jul 8, 2020
@chef-expeditor chef-expeditor bot deleted the platform_spike branch July 8, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants