Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: windows file failed to initialize with new symlink handler #96

Merged
merged 2 commits into from
Apr 29, 2016

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Apr 29, 2016

Fixes:

inspec> f=file('c:\Users\vagrant')
ArgumentError: wrong number of arguments (2 for 3)
from /Users/apop/.chefdk/gem/ruby/2.1.0/gems/r-train-0.11.1/lib/train/extras/file_windows.rb:14:in `initialize'

@arlimus arlimus added the bug label Apr 29, 2016
@alexpop
Copy link
Contributor

alexpop commented Apr 29, 2016

Fixes the issue:

inspec> f=file('C:\Users\vagrant')
=> File C:\Users\vagrant
inspec> f.path
=> "C:\\Users\\vagrant"
inspec> f.directory?
=> true
inspec> f.basename
=> "vagrant"
inspec> f.exist?
=> true

Thanks for the quick turnaround Dom!

@alexpop
Copy link
Contributor

alexpop commented Apr 29, 2016

These appveyor failure seems to be related to bundler issue 4472

@alexpop alexpop force-pushed the dr/windowsfile-symlink-issue branch from e605904 to 39561eb Compare April 29, 2016 18:23
@alexpop
Copy link
Contributor

alexpop commented Apr 29, 2016

Thanks Dom!

@alexpop alexpop merged commit 73b962b into master Apr 29, 2016
@arlimus arlimus deleted the dr/windowsfile-symlink-issue branch April 29, 2016 21:38
@clintoncwolfe clintoncwolfe added Type: Bug Feature not working as expected and removed Type: Bug labels Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants