feat: add Node.js 16 to test matrix #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
ci-node-15-16
branch
4 times, most recently
from
73d858e to
1cd55c5
Compare
https-proxy-agent specifies a loose version range for its dependency
agent-base ("agent-base": "6"). In Node.js 15 and 16, [email protected]
is broken for the use case of an HTTPS connection with an HTTP proxy.
Thus, we need to ensure that [email protected] is used, which contains
the fix
(TooTallNate/node-agent-base@a5c5c83).
To do that, we include [email protected] explicitly in
packages/serverless/package.json. If https-proxy-agent releases an
update with a version range for agent-base that includes this fix, we
can remove that dependency again (we do not actually depend on
agent-base directly).
Also, drop precompiled add-ons for Node.js 6 to reduce package size.
...by running `native-dep-packs/rebuild-precompiled-addons.sh`. This commit also removes precompiled add-ons for Node.js 6 to reduce package size.
basti1302
changed the title
- add Node.js 16 - stop building precompiled add-on for Node.js 6 - remove precompiled binaries for Darwin from list of files included in npm package - add precompiled binaries for autoprofile for Darwin to .gitignore - fix issue with building for Node.js target version 10.x/11.x
...by running `packages/autoprofile/precompile/build-all-addons.js`. This commit also removes the precompiled autoprofile add-on binaries for Darwin and for Node.js 6, it adds binaries for Node.js 16.
willianpc
commented
Jun 8, 2021
basti1302
approved these changes
Jun 8, 2021
Node.js 15 is a non-LTS version and it is end of life since 2021-06-01. Although all Instana packages work perfectly fine with Node.js 15, it is no longer officially supported. See Instana's Node.js version support policy at https://www.instana.com/docs/ecosystem/node-js/#supported-nodejs-versions for details. Node.js 6, 8, 10, 12, 14 and 16 are the currently supported versions.
Also, make the legacy package test suite use different ports from the @instana/collector suite to avoid port conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.